Notes are not saved

Description

Below a snippet of the email that reports the issue.

_A reviewer has flagged an issue when saving files, the notes done are not saved. She updated to the latest version but still get the same issue. I tried on my end and get the same result. The notes section is active as per instructions, but they are not there when I close and reopen the file after saving it. _

Environment

None

Activity

Show:
Marta Borriello
June 9, 2017, 3:16 PM

Okapi changed the way of reading and writing notes in XLIFF 1.2.
The XLIFFFilter now uses the XLIFFNoteAnnotation, while Ocelot was still managing notes by means of the Property.NOTE (now deprecated).

I've updated the code in Ocelot accordingly and now notes are properly read and written again.
By the way, as the XLIFFNoteAnnotation can contain more than one note, I needed a way to discern which note has been created by Ocelot. I've adopted the following strategy (very similar to the alt-trans management):

  • all notes created in Ocelot have the "from" attribute set to "ocelot"

  • Ocelot only reads notes having the "from" attribute set to "ocelot"

Note that this behavior is not backward compatible in the sense that notes saved by previous version of Ocelot won't be read by this version.

Fixed

Assignee

Marta Borriello

Reporter

Marta Borriello

Labels

None

Fix versions

Priority

Major